From: Jonathan Corbet <corbet@lwn.net>
Date: Tue, 31 Mar 2026 14:31:58 +0000 (-0600)
Subject: Revert "scripts/checkpatch: add Assisted-by: tag validation"
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=83725f1d980b92789f99db0ea756979017c37ac3;p=thirdparty%2Flinux.git

Revert "scripts/checkpatch: add Assisted-by: tag validation"

This reverts commit 8545d9bc4bd0801e0bdfbfdfdc2532ff31236ddf.

Unbeknownst to me, and unremarked upon by the checkpatch maintainer, this
same problem was also solved in the mm tree.  Fixing it once is enough, so
this one comes out.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b8d961d77ff4e..e56374662ff79 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -641,7 +641,6 @@ our $signature_tags = qr{(?xi:
 	Reviewed-by:|
 	Reported-by:|
 	Suggested-by:|
-	Assisted-by:|
 	To:|
 	Cc:
 )};
@@ -738,7 +737,7 @@ sub find_standard_signature {
 	my ($sign_off) = @_;
 	my @standard_signature_tags = (
 		'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
-		'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 'Assisted-by:'
+		'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
 	);
 	foreach my $signature (@standard_signature_tags) {
 		return $signature if (get_edit_distance($sign_off, $signature) <= 2);
@@ -3106,15 +3105,6 @@ sub process {
 				}
 			}
 
-# Assisted-by: uses format AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2] instead of email
-			if ($sign_off =~ /^assisted-by:$/i) {
-				if ($email !~ /^[^:]+:\S+(\s+\S+)*$/) {
-					WARN("BAD_ASSISTED_BY",
-					     "Assisted-by: should use format: 'Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]'\n" . $herecurr);
-				}
-				next;
-			}
-
 			my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
 			my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
 			if ($suggested_email eq "") {