From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 10 Jan 2009 03:18:00 +0000 (+1300)
Subject: SMB_LM: replace assertion with clean error report
X-Git-Tag: SQUID_3_2_0_1~1274
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=83ae34bc5936c1ec041476a83c75c1ea4a1d466c;p=thirdparty%2Fsquid.git

SMB_LM: replace assertion with clean error report
---

diff --git a/helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.c b/helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.c
index bf4464bb64..7c97d14395 100644
--- a/helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.c
+++ b/helpers/ntlm_auth/smb_lm/ntlm_smb_lm_auth.c
@@ -316,8 +316,7 @@ manage_request()
             return;
             /* notreached */
         case NTLM_CHALLENGE:
-            SEND
-            ("NA Got a challenge. We refuse to have our authority disputed");
+            SEND("NA Got a challenge. We refuse to have our authority disputed");
             return;
             /* notreached */
         case NTLM_AUTHENTICATE:
@@ -415,8 +414,10 @@ manage_request()
                                   (ntlm_authenticate *) decoded, plen);
                     return;
                 }
+                SEND("BH unknown internal error.");
+                return;
             }
-            assert(cred != NULL);
+
             lc(cred);		/* let's lowercase them for our convenience */
             SEND2("AF %s", cred);
             return;