From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Fri, 22 Sep 2023 09:19:37 +0000 (+0200)
Subject: lib/env: avoid underflow of read_all_alloc() return value
X-Git-Tag: v2.39.3~51
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=83ba179b12d3c6c5f400bf78f2f742b1cc7ce256;p=thirdparty%2Futil-linux.git

lib/env: avoid underflow of read_all_alloc() return value

read_all_alloc() returns a negative error on failure.
When casting this to an unsigned type the failure check "< 1"
will not work.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/lib/env.c b/lib/env.c
index 2ccabff6fc..2b3395c53b 100644
--- a/lib/env.c
+++ b/lib/env.c
@@ -90,7 +90,7 @@ static struct ul_env_list *env_list_add(struct ul_env_list *ls0, const char *str
 struct ul_env_list *env_from_fd(int fd)
 {
 	char *buf = NULL, *p;
-	size_t rc = 0;
+	ssize_t rc = 0;
 	struct ul_env_list *ls = NULL;
 
 	if ((rc = read_all_alloc(fd, &buf)) < 1)