From: Guido van Rossum <guido@python.org>
Date: Mon, 27 Nov 2000 22:22:36 +0000 (+0000)
Subject: Plug a memory leak in com_import_stmt(): the tuple created to hold the
X-Git-Tag: v2.1a1~707
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=83fb073a0307e5585cc99fce52c169c0fa8562f4;p=thirdparty%2FPython%2Fcpython.git

Plug a memory leak in com_import_stmt(): the tuple created to hold the
"..." in "from M import ..." was never DECREFed.  Leak reported by
James Slaughter and nailed by Barry, who also provided an earlier
version of this patch.
---

diff --git a/Python/compile.c b/Python/compile.c
index 77ae001c1114..aca1705b211a 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -2325,11 +2325,11 @@ static void
 com_import_stmt(struct compiling *c, node *n)
 {
 	int i;
-	PyObject *tup;
 	REQ(n, import_stmt);
 	/* 'import' dotted_name (',' dotted_name)* |
 	   'from' dotted_name 'import' ('*' | NAME (',' NAME)*) */
 	if (STR(CHILD(n, 0))[0] == 'f') {
+		PyObject *tup;
 		/* 'from' dotted_name 'import' ... */
 		REQ(CHILD(n, 1), dotted_name);
 		
@@ -2344,6 +2344,7 @@ com_import_stmt(struct compiling *c, node *n)
 			}
 		}
 		com_addoparg(c, LOAD_CONST, com_addconst(c, tup));
+		Py_DECREF(tup);
 		com_push(c, 1);
 		com_addopname(c, IMPORT_NAME, CHILD(n, 1));
 		if (TYPE(CHILD(n, 3)) == STAR)