From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 29 May 2018 15:01:53 +0000 (+0200)
Subject: journal: small simplification
X-Git-Tag: v239~157^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=846e541830bce41fcea2f197ae1c8b34e2308cb6;p=thirdparty%2Fsystemd.git

journal: small simplification
---

diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
index 606ca604acf..c9b6466bab7 100644
--- a/src/journal/journal-file.c
+++ b/src/journal/journal-file.c
@@ -212,7 +212,7 @@ int journal_file_set_offline(JournalFile *f, bool wait) {
         if (!f->writable)
                 return -EPERM;
 
-        if (!(f->fd >= 0 && f->header))
+        if (f->fd < 0 || !f->header)
                 return -EINVAL;
 
         /* An offlining journal is implicitly online and may modify f->header->state,
@@ -269,7 +269,7 @@ static int journal_file_set_online(JournalFile *f) {
         if (!f->writable)
                 return -EPERM;
 
-        if (!(f->fd >= 0 && f->header))
+        if (f->fd < 0 || !f->header)
                 return -EINVAL;
 
         while (wait) {