From: Jeremy Allison <jra@samba.org>
Date: Mon, 4 Jun 2007 22:29:23 +0000 (+0000)
Subject: r23346: Fix offline caching with XP/Vista. It was an off-by-one
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~270
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=84801d4e83786b9de3d0875a317ca9ed8ff5b3e4;p=thirdparty%2Fsamba.git

r23346: Fix offline caching with XP/Vista. It was an off-by-one
in storing the access mask. I shouldn't have made this
mistake. Damn. Fixes bug #4673.
Jeremy
---

diff --git a/source/smbd/nttrans.c b/source/smbd/nttrans.c
index a1edc99bceb..71e6dd47b46 100644
--- a/source/smbd/nttrans.c
+++ b/source/smbd/nttrans.c
@@ -420,7 +420,7 @@ static int do_ntcreate_pipe_open(connection_struct *conn,
 	p += 4;
 
 	if (flags & EXTENDED_RESPONSE_REQUIRED) {
-		p += 26;
+		p += 25;
 		SIVAL(p,0,FILE_GENERIC_ALL);
 		/* 
 		 * For pipes W2K3 seems to return
@@ -950,7 +950,7 @@ int reply_ntcreate_and_X(connection_struct *conn,
 
 	if (flags & EXTENDED_RESPONSE_REQUIRED) {
 		uint32 perms = 0;
-		p += 26;
+		p += 25;
 		if (fsp->is_directory || can_write_to_file(conn, fname, &sbuf)) {
 			perms = FILE_GENERIC_ALL;
 		} else {
@@ -1035,7 +1035,7 @@ static int do_nt_transact_create_pipe( connection_struct *conn, char *inbuf, cha
 	p += 4;
 	
 	if (flags & EXTENDED_RESPONSE_REQUIRED) {
-		p += 26;
+		p += 25;
 		SIVAL(p,0,FILE_GENERIC_ALL);
 		/* 
 		 * For pipes W2K3 seems to return
@@ -1631,7 +1631,7 @@ static int call_nt_transact_create(connection_struct *conn, char *inbuf, char *o
 
 	if (flags & EXTENDED_RESPONSE_REQUIRED) {
 		uint32 perms = 0;
-		p += 26;
+		p += 25;
 		if (fsp->is_directory || can_write_to_file(conn, fname, &sbuf)) {
 			perms = FILE_GENERIC_ALL;
 		} else {