From: Noel Power <noel.power@suse.com>
Date: Tue, 9 Jul 2019 14:08:49 +0000 (+0000)
Subject: lib/adnss: clang: Fix The left operand of '!=' is a garbage value
X-Git-Tag: tdb-1.4.2~485
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=849ffbc8251aa193cfcab043ab7c818a666a4a68;p=thirdparty%2Fsamba.git

lib/adnss: clang: Fix The left operand of '!=' is a garbage value

Fixes:

lib/addns/dnssock.c:143:3: warning: The left operand of '!=' is a garbage value <--[clang]
                TALLOC_FREE(conn);
                ^
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/lib/addns/dnssock.c b/lib/addns/dnssock.c
index 30b8fa2eaf4..11f2e00a57b 100644
--- a/lib/addns/dnssock.c
+++ b/lib/addns/dnssock.c
@@ -125,7 +125,7 @@ static DNS_ERROR dns_udp_open( const char *nameserver,
 {
 	struct addrinfo hints;
 	struct sockaddr_storage RecvAddr;
-	struct dns_connection *conn;
+	struct dns_connection *conn = NULL;
 	DNS_ERROR dns_ret;
 	socklen_t RecvAddrLen;
 	char service[16];