From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Thu, 3 Jul 2025 10:17:10 +0000 (+0200) Subject: [3.14] Fix comments for `heapq.siftup_max` (GH-135359) (#136232) X-Git-Tag: v3.14.0b4~44 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=84cafc7e94552fc6393df9948bfb93a89a25c669;p=thirdparty%2FPython%2Fcpython.git [3.14] Fix comments for `heapq.siftup_max` (GH-135359) (#136232) Fix comments for `heapq.siftup_max` (GH-135359) (cherry picked from commit 8f8bdf251a5f79d15ac2b1a6d19860033bf50c79) Co-authored-by: Alper Co-authored-by: mpage --- diff --git a/Modules/_heapqmodule.c b/Modules/_heapqmodule.c index 560fe431fcac..05d01acd7710 100644 --- a/Modules/_heapqmodule.c +++ b/Modules/_heapqmodule.c @@ -463,11 +463,11 @@ siftup_max(PyListObject *heap, Py_ssize_t pos) return -1; } - /* Bubble up the smaller child until hitting a leaf. */ + /* Bubble up the larger child until hitting a leaf. */ arr = _PyList_ITEMS(heap); limit = endpos >> 1; /* smallest pos that has no child */ while (pos < limit) { - /* Set childpos to index of smaller child. */ + /* Set childpos to index of larger child. */ childpos = 2*pos + 1; /* leftmost child position */ if (childpos + 1 < endpos) { PyObject* a = arr[childpos + 1]; @@ -487,7 +487,7 @@ siftup_max(PyListObject *heap, Py_ssize_t pos) return -1; } } - /* Move the smaller child up. */ + /* Move the larger child up. */ tmp1 = arr[childpos]; tmp2 = arr[pos]; FT_ATOMIC_STORE_PTR_RELAXED(arr[childpos], tmp2);