From: Kangjie Lu <kangjielu@gmail.com>
Date: Tue, 3 May 2016 20:44:07 +0000 (-0400)
Subject: ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS
X-Git-Tag: v3.16.37~28
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=84d8697290dd3b2c08be651651a02d30f62d91a7;p=thirdparty%2Fkernel%2Fstable.git

ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS

commit cec8f96e49d9be372fdb0c3836dcf31ec71e457e upstream.

The stack object “tread” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---

diff --git a/sound/core/timer.c b/sound/core/timer.c
index 7dfb741a91b4d..139efdd74ac8c 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1750,6 +1750,7 @@ static int snd_timer_user_params(struct file *file,
 	if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
 		if (tu->tread) {
 			struct snd_timer_tread tread;
+			memset(&tread, 0, sizeof(tread));
 			tread.event = SNDRV_TIMER_EVENT_EARLY;
 			tread.tstamp.tv_sec = 0;
 			tread.tstamp.tv_nsec = 0;