From: Travis Cross <tc@traviscross.com>
Date: Thu, 29 May 2014 13:15:44 +0000 (+0000)
Subject: Remove tautological condition check
X-Git-Tag: v1.4.5~2^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=84fe7b07941e5c40bf16b45df2c7fb520b7d3d4a;p=thirdparty%2Ffreeswitch.git

Remove tautological condition check

We already decided to goto end if node is null, so it cannot be null
here.
---

diff --git a/src/mod/applications/mod_fifo/mod_fifo.c b/src/mod/applications/mod_fifo/mod_fifo.c
index 2a0f82d369..768ed67847 100644
--- a/src/mod/applications/mod_fifo/mod_fifo.c
+++ b/src/mod/applications/mod_fifo/mod_fifo.c
@@ -1459,14 +1459,10 @@ static void *SWITCH_THREAD_FUNC outbound_ringall_thread_run(switch_thread_t *thr
 		goto end;
 	}
 
-	if (node) {
-		switch_mutex_lock(node->update_mutex);
-		node->busy = 0;
-		node->ring_consumer_count = 1;
-		switch_mutex_unlock(node->update_mutex);
-	} else {
-		goto end;
-	}
+	switch_mutex_lock(node->update_mutex);
+	node->busy = 0;
+	node->ring_consumer_count = 1;
+	switch_mutex_unlock(node->update_mutex);
 
 	SWITCH_STANDARD_STREAM(stream);
 	SWITCH_STANDARD_STREAM(stream2);