From: Russell Bryant <russell@russellbryant.com>
Date: Fri, 7 Dec 2007 02:38:40 +0000 (+0000)
Subject: Allow dialing local channels from Queue() and Dial() again.  There was a slight
X-Git-Tag: 1.4.16~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=85e0e1919d1726efaef2e5fa44080bda36906d4e;p=thirdparty%2Fasterisk.git

Allow dialing local channels from Queue() and Dial() again.  There was a slight
flaw in the code to prevent call forwards from looping that caused this problem.
(related to issue #11486)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@91677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_dial.c b/apps/app_dial.c
index cc9722e93c..b89f520974 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1159,7 +1159,7 @@ static int dial_exec_full(struct ast_channel *chan, void *data, struct ast_flags
 			}
 			strcpy(di->interface, interface);
 			AST_LIST_INSERT_TAIL(dialed_interfaces, di, list);
-		} else {
+		} else if (dialed) {
 			AST_LIST_UNLOCK(dialed_interfaces);
 			ast_log(LOG_WARNING, "Skipping dialing interface '%s' again since it has already been dialed\n", di->interface);
 			fulldial++;
diff --git a/apps/app_queue.c b/apps/app_queue.c
index 8868e9c570..8606ede2fb 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -2604,9 +2604,8 @@ static int try_calling(struct queue_ent *qe, const char *options, char *announce
 			}
 			strcpy(di->interface, cur->interface);
 			AST_LIST_INSERT_TAIL(dialed_interfaces, di, list);
-		} else {
-			if (di)
-				ast_log(LOG_DEBUG, "Skipping dialing interface '%s' since it has already been dialed\n", di->interface);
+		} else if (dialed) {
+			ast_log(LOG_DEBUG, "Skipping dialing interface '%s' since it has already been dialed\n", di->interface);
 			AST_LIST_UNLOCK(dialed_interfaces);
 			free(tmp);
 			continue;