From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 14 Sep 2023 09:47:44 +0000 (+0300)
Subject: bcachefs: fix error checking in bch2_fs_alloc()
X-Git-Tag: v6.7-rc1~201^2~52
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=867c1fe0187f6df4dca84a34332e00f21ef80f69;p=thirdparty%2Fkernel%2Flinux.git

bcachefs: fix error checking in bch2_fs_alloc()

There is a typo here where it uses ";" instead of "?:".  The result is
that bch2_fs_fs_io_direct_init() is called unconditionally and the errors
from it are not checked.

Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Reviewed-by: Brian Foster <bfoster@redhat.com>
---

diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 2990eed85adf5..e94a63a22704a 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -852,7 +852,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts)
 	    bch2_fs_compress_init(c) ?:
 	    bch2_fs_ec_init(c) ?:
 	    bch2_fs_fsio_init(c) ?:
-	    bch2_fs_fs_io_buffered_init(c);
+	    bch2_fs_fs_io_buffered_init(c) ?:
 	    bch2_fs_fs_io_direct_init(c);
 	if (ret)
 		goto err;