From: Anthony Sottile <asottile@umich.edu>
Date: Wed, 13 Mar 2019 03:57:09 +0000 (-0700)
Subject: Fix stepping into a frame without a __name__ (GH-12064)
X-Git-Tag: v3.8.0a3~112
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86900a49000c4a96ad1dc34e49d8af4245b08843;p=thirdparty%2FPython%2Fcpython.git

Fix stepping into a frame without a __name__ (GH-12064)
---

diff --git a/Lib/bdb.py b/Lib/bdb.py
index 25c6260c47c7..ec0f92c06a78 100644
--- a/Lib/bdb.py
+++ b/Lib/bdb.py
@@ -190,6 +190,8 @@ class Bdb:
 
     def is_skipped_module(self, module_name):
         "Return True if module_name matches any skip pattern."
+        if module_name is None:  # some modules do not have names
+            return False
         for pattern in self.skip:
             if fnmatch.fnmatch(module_name, pattern):
                 return True
diff --git a/Lib/test/test_bdb.py b/Lib/test/test_bdb.py
index 751dd9f69597..6e82cce1f411 100644
--- a/Lib/test/test_bdb.py
+++ b/Lib/test/test_bdb.py
@@ -730,6 +730,13 @@ class StateTestCase(BaseTestCase):
             with TracerRun(self, skip=skip) as tracer:
                 tracer.runcall(tfunc_import)
 
+    def test_skip_with_no_name_module(self):
+        # some frames have `globals` with no `__name__`
+        # for instance the second frame in this traceback
+        # exec(compile('raise ValueError()', '', 'exec'), {})
+        bdb = Bdb(skip=['anything*'])
+        self.assertIs(bdb.is_skipped_module(None), False)
+
     def test_down(self):
         # Check that set_down() raises BdbError at the newest frame.
         self.expect_set = [
diff --git a/Misc/NEWS.d/next/Library/2019-02-26-22-41-38.bpo-36130._BnZOo.rst b/Misc/NEWS.d/next/Library/2019-02-26-22-41-38.bpo-36130._BnZOo.rst
new file mode 100644
index 000000000000..3bab152871f3
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2019-02-26-22-41-38.bpo-36130._BnZOo.rst
@@ -0,0 +1,2 @@
+Fix ``pdb`` with ``skip=...`` when stepping into a frame without a
+``__name__`` global.  Patch by Anthony Sottile.