From: Nick Mathewson Date: Tue, 22 May 2012 13:51:02 +0000 (-0400) Subject: Note some annoyinc copy-and-paste code X-Git-Tag: tor-0.2.4.11-alpha~17^2~5 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=869826581d01ae430b15721b0ff25ebe94103d1a;p=thirdparty%2Ftor.git Note some annoyinc copy-and-paste code --- diff --git a/src/or/dirvote.c b/src/or/dirvote.c index d1ac8f8e94..96fc8a534f 100644 --- a/src/or/dirvote.c +++ b/src/or/dirvote.c @@ -1590,6 +1590,7 @@ networkstatus_compute_consensus(smartlist_t *votes, if (consensus_method >= MIN_METHOD_TO_CLIP_UNMEASURED_BW) { char *max_unmeasured_param = NULL; + /* XXXX Extract this code into a common function */ if (params) { if (strcmpstart(params, "maxunmeasuredbw=") == 0) max_unmeasured_param = params; @@ -2097,6 +2098,7 @@ networkstatus_compute_consensus(smartlist_t *votes, // Parse params, extract BW_WEIGHT_SCALE if present // DO NOT use consensus_param_bw_weight_scale() in this code! // The consensus is not formed yet! + /* XXXX Extract this code into a common function */ if (params) { if (strcmpstart(params, "bwweightscale=") == 0) bw_weight_param = params;