From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 29 Oct 2018 05:15:12 +0000 (-0700)
Subject: Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)
X-Git-Tag: v3.6.8rc1~164
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86a0f222cedc580413dd25d3565beef51ee24e5b;p=thirdparty%2FPython%2Fcpython.git

Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)

(cherry picked from commit 53835e92d315340444e3dd083b3f69a590b00e07)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
---

diff --git a/Modules/termios.c b/Modules/termios.c
index b78d33e6889a..945d8e08e6a2 100644
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -113,11 +113,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
     PyList_SetItem(v, 3, PyLong_FromLong((long)mode.c_lflag));
     PyList_SetItem(v, 4, PyLong_FromLong((long)ispeed));
     PyList_SetItem(v, 5, PyLong_FromLong((long)ospeed));
-    PyList_SetItem(v, 6, cc);
-    if (PyErr_Occurred()){
+    if (PyErr_Occurred()) {
         Py_DECREF(v);
         goto err;
     }
+    PyList_SetItem(v, 6, cc);
     return v;
   err:
     Py_DECREF(cc);