From: Tom Krizek Date: Fri, 12 Jan 2024 14:03:53 +0000 (+0100) Subject: Export variable in resolver system test X-Git-Tag: v9.19.23~17^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86a192cecea5413db85b30fb478cc48986452fe4;p=thirdparty%2Fbind9.git Export variable in resolver system test Variable assignment when calling subroutines might not be portable. Notably, it doesn't work with FreeBSD shell, where the value of HOME would be ignored in this case. Since the commands are already executed in a subshell, export the HOME variable to ensure it is properly handled in all shells. --- diff --git a/bin/tests/system/resolver/tests.sh b/bin/tests/system/resolver/tests.sh index c4461971263..7ada50fe183 100755 --- a/bin/tests/system/resolver/tests.sh +++ b/bin/tests/system/resolver/tests.sh @@ -505,9 +505,21 @@ n=$((n + 1)) echo_i "check that '-t aaaa' in .digrc does not have unexpected side effects ($n)" ret=0 echo "-t aaaa" >.digrc -(HOME="$(pwd)" dig_with_opts @10.53.0.4 . >dig.out.1.${n}) || ret=1 -(HOME="$(pwd)" dig_with_opts @10.53.0.4 . A >dig.out.2.${n}) || ret=1 -(HOME="$(pwd)" dig_with_opts @10.53.0.4 -x 127.0.0.1 >dig.out.3.${n}) || ret=1 +( + HOME="$(pwd)" + export HOME + dig_with_opts @10.53.0.4 . >dig.out.1.${n} +) || ret=1 +( + HOME="$(pwd)" + export HOME + dig_with_opts @10.53.0.4 . A >dig.out.2.${n} +) || ret=1 +( + HOME="$(pwd)" + export HOME + dig_with_opts @10.53.0.4 -x 127.0.0.1 >dig.out.3.${n} +) || ret=1 grep ';\..*IN.*AAAA$' dig.out.1.${n} >/dev/null || ret=1 grep ';\..*IN.*A$' dig.out.2.${n} >/dev/null || ret=1 grep 'extra type option' dig.out.2.${n} >/dev/null && ret=1