From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 18 Apr 2017 21:14:48 +0000 (-0400)
Subject: meson: use "sh -eu" and make .sh +x, .py -x
X-Git-Tag: v234~286^2~22
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86b3ca7a667baef407ccfa28166638ed0e64c26c;p=thirdparty%2Fsystemd.git

meson: use "sh -eu" and make .sh +x, .py -x

Shell scripts should be executable so that meson reports their
invocation succinctly (does not print 'sh' '-e').
Python scripts should not be executable so that meson does the
detection of the right python binary itself.

Add -u everywhere to catch potential errors.
---

diff --git a/src/basic/generate-af-list.sh b/src/basic/generate-af-list.sh
old mode 100644
new mode 100755
index 3fdfe2ea601..733cf59dd0d
--- a/src/basic/generate-af-list.sh
+++ b/src/basic/generate-af-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -eu
 
 $1 -E -dM -include sys/socket.h - </dev/null | \
     grep -Ev 'AF_UNSPEC|AF_MAX' | \
diff --git a/src/basic/generate-arphrd-list.sh b/src/basic/generate-arphrd-list.sh
old mode 100644
new mode 100755
index 9911f315fa1..3c2bc5483dd
--- a/src/basic/generate-arphrd-list.sh
+++ b/src/basic/generate-arphrd-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 $1 -dM -include net/if_arp.h - </dev/null | \
     awk '/^#define[ \t]+ARPHRD_[^ \t]+[ \t]+[^ \t]/ { print $2; }' | \
diff --git a/src/basic/generate-cap-list.sh b/src/basic/generate-cap-list.sh
old mode 100644
new mode 100755
index b79468cd597..3ac3544539d
--- a/src/basic/generate-cap-list.sh
+++ b/src/basic/generate-cap-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 $1 -dM -include linux/capability.h -include "$2" -include "$3" - </dev/null | \
     awk '/^#define[ \t]+CAP_[A-Z_]+[ \t]+/ { print $2; }' | \
diff --git a/src/basic/generate-errno-list.sh b/src/basic/generate-errno-list.sh
old mode 100644
new mode 100755
index a80990ac242..a8b49386447
--- a/src/basic/generate-errno-list.sh
+++ b/src/basic/generate-errno-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 $1 -dM -include errno.h - </dev/null | \
     awk '/^#define[ \t]+E[^ _]+[ \t]+/ { print $2; }'
diff --git a/src/boot/efi/no-undefined-symbols.sh b/src/boot/efi/no-undefined-symbols.sh
old mode 100644
new mode 100755
index 4d920828252..14a1a087bb1
--- a/src/boot/efi/no-undefined-symbols.sh
+++ b/src/boot/efi/no-undefined-symbols.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 if nm -D -u "$1" | grep ' U '; then
     echo "Undefined symbols detected!"
diff --git a/src/journal/generate-audit_type-list.sh b/src/journal/generate-audit_type-list.sh
old mode 100644
new mode 100755
index edd2b279944..c9476b7809b
--- a/src/journal/generate-audit_type-list.sh
+++ b/src/journal/generate-audit_type-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 cpp="$1"
 shift
diff --git a/src/test/generate-sym-test.py b/src/test/generate-sym-test.py
old mode 100755
new mode 100644
diff --git a/src/udev/generate-keyboard-keys-list.sh b/src/udev/generate-keyboard-keys-list.sh
old mode 100644
new mode 100755
index 91635caebcf..5fb5ed0bbed
--- a/src/udev/generate-keyboard-keys-list.sh
+++ b/src/udev/generate-keyboard-keys-list.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 $1 -dM -include linux/input.h - </dev/null | \
     awk '/^#define[ \t]+KEY_[^ ]+[ \t]+[0-9K]/ { if ($2 != "KEY_MAX") { print $2 } }'
diff --git a/tools/meson-check-compilation.sh b/tools/meson-check-compilation.sh
old mode 100644
new mode 100755
index 9bbe54669be..e24194247e6
--- a/tools/meson-check-compilation.sh
+++ b/tools/meson-check-compilation.sh
@@ -1,3 +1,3 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 "$@" '-' '-c' -o/dev/null </dev/null
diff --git a/tools/meson-check-help.sh b/tools/meson-check-help.sh
index 2f7ba3978d4..7102866a5c2 100755
--- a/tools/meson-check-help.sh
+++ b/tools/meson-check-help.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 # output width
 if "$1"  --help | grep -v 'default:' | grep -E -q '.{80}.'; then
diff --git a/tools/meson-git-contrib.sh b/tools/meson-git-contrib.sh
old mode 100644
new mode 100755
index c9d3775bcfa..ac031638e0d
--- a/tools/meson-git-contrib.sh
+++ b/tools/meson-git-contrib.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 git shortlog -s `git describe --abbrev=0`.. | \
     cut -c8- | \
diff --git a/tools/meson-hwdb-update.sh b/tools/meson-hwdb-update.sh
index f97e65c9af0..4c919073bb8 100755
--- a/tools/meson-hwdb-update.sh
+++ b/tools/meson-hwdb-update.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -ex
+#!/bin/sh -eu
 
 cd "$1"
 
diff --git a/tools/meson-make-symlink.sh b/tools/meson-make-symlink.sh
old mode 100644
new mode 100755
index 87f198694ca..69eab9ba733
--- a/tools/meson-make-symlink.sh
+++ b/tools/meson-make-symlink.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 # this is needed mostly because $DESTDIR is provided as a variable,
 # and we need to create the target directory...
diff --git a/units/meson-add-wants.sh b/units/meson-add-wants.sh
old mode 100644
new mode 100755
index ce93d712555..7fbf5ed6fc9
--- a/units/meson-add-wants.sh
+++ b/units/meson-add-wants.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/sh -eu
 
 unitdir="$1"
 target="$2"