From: Sergey B Kirpichev Date: Wed, 29 May 2024 06:57:50 +0000 (+0300) Subject: gh-119555: catch SyntaxError from compile() in the InteractiveColoredConsole (#119557) X-Git-Tag: v3.14.0a1~1726 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86d1a1aa8841ea182eaf434ae6b942b3e93f58db;p=thirdparty%2FPython%2Fcpython.git gh-119555: catch SyntaxError from compile() in the InteractiveColoredConsole (#119557) --- diff --git a/Lib/_pyrepl/simple_interact.py b/Lib/_pyrepl/simple_interact.py index b5f182ebfe71..11e831c1d6c5 100644 --- a/Lib/_pyrepl/simple_interact.py +++ b/Lib/_pyrepl/simple_interact.py @@ -101,7 +101,7 @@ class InteractiveColoredConsole(code.InteractiveConsole): item = wrapper([stmt]) try: code = compile(item, filename, the_symbol, dont_inherit=True) - except (OverflowError, ValueError): + except (OverflowError, ValueError, SyntaxError): self.showsyntaxerror(filename) return False diff --git a/Lib/test/test_pyrepl/test_interact.py b/Lib/test/test_pyrepl/test_interact.py index 6ebd51fe14dd..4d01ea762010 100644 --- a/Lib/test/test_pyrepl/test_interact.py +++ b/Lib/test/test_pyrepl/test_interact.py @@ -94,6 +94,14 @@ class TestSimpleInteract(unittest.TestCase): with patch.object(console, "showsyntaxerror") as mock_showsyntaxerror: console.runsource(source) mock_showsyntaxerror.assert_called_once() + source = dedent("""\ + match 1: + case {0: _, 0j: _}: + pass + """) + with patch.object(console, "showsyntaxerror") as mock_showsyntaxerror: + console.runsource(source) + mock_showsyntaxerror.assert_called_once() def test_no_active_future(self): console = InteractiveColoredConsole() diff --git a/Misc/NEWS.d/next/Library/2024-05-25-20-15-26.gh-issue-119555.mvHbEL.rst b/Misc/NEWS.d/next/Library/2024-05-25-20-15-26.gh-issue-119555.mvHbEL.rst new file mode 100644 index 000000000000..e16cb28b471a --- /dev/null +++ b/Misc/NEWS.d/next/Library/2024-05-25-20-15-26.gh-issue-119555.mvHbEL.rst @@ -0,0 +1,2 @@ +Catch :exc:`SyntaxError` from :func:`compile` in the runsource() method of +the InteractiveColoredConsole. Patch by Sergey B Kirpichev.