From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 2 Nov 2023 01:32:00 +0000 (+1300)
Subject: tests/krb5: Don’t reuse SID S-1-2-3-4
X-Git-Tag: talloc-2.4.2~858
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=86fb7d17ff7683c66ce74e16b3be927b97ea5e5d;p=thirdparty%2Fsamba.git

tests/krb5: Don’t reuse SID S-1-2-3-4

We’re already using it in ‘client_sids’ to work around a bug in Windows.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/conditional_ace_tests.py b/python/samba/tests/krb5/conditional_ace_tests.py
index c51ffb85d2e..017720338a8 100755
--- a/python/samba/tests/krb5/conditional_ace_tests.py
+++ b/python/samba/tests/krb5/conditional_ace_tests.py
@@ -4482,8 +4482,8 @@ class TgsReqServicePolicyTests(ConditionalAceBaseTests):
             ('S-1-2-3-4', SidType.EXTRA_SID, self.default_attrs),
         }
 
-        device_sid_0 = 'S-1-2-3-4'
-        device_sid_1 = 'S-1-3-4-5'
+        device_sid_0 = 'S-1-3-4-5'
+        device_sid_1 = 'S-1-4-5-6'
 
         policy_sids = {
             'device_0': device_sid_0,
@@ -4592,8 +4592,8 @@ class TgsReqServicePolicyTests(ConditionalAceBaseTests):
             expected_device_sids = {
                 (security.DOMAIN_RID_USERS, SidType.BASE_SID, self.default_attrs),
                 (security.DOMAIN_RID_USERS, SidType.PRIMARY_GID, None),
-                ('S-1-2-3-4', SidType.EXTRA_SID, self.resource_attrs),
                 ('S-1-3-4-5', SidType.EXTRA_SID, self.resource_attrs),
+                ('S-1-4-5-6', SidType.EXTRA_SID, self.resource_attrs),
             }
 
             if device_claims_valid: