From: Ralph Boehme <slow@samba.org>
Date: Thu, 2 Apr 2020 08:27:21 +0000 (+0200)
Subject: smbd: fix if expression that checks when to call vfs_fill_sparse()
X-Git-Tag: ldb-2.2.0~1000
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8718dae6b8aee461c8207d14bf3d8d8361cab829;p=thirdparty%2Fsamba.git

smbd: fix if expression that checks when to call vfs_fill_sparse()

Noone complained so far, skip bugreport.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/fileio.c b/source3/smbd/fileio.c
index 31d5b7510b7..272262d78cd 100644
--- a/source3/smbd/fileio.c
+++ b/source3/smbd/fileio.c
@@ -71,8 +71,8 @@ static ssize_t real_write_file(struct smb_request *req,
 	ssize_t ret;
 
 	fsp->fh->pos = pos;
-	if (pos && lp_strict_allocate(SNUM(fsp->conn) &&
-			!fsp->is_sparse)) {
+	if (pos && lp_strict_allocate(SNUM(fsp->conn)) &&
+			!fsp->is_sparse) {
 		if (vfs_fill_sparse(fsp, pos) == -1) {
 			return -1;
 		}