From: Sam Gross <colesbury@gmail.com>
Date: Fri, 31 May 2024 18:18:24 +0000 (-0400)
Subject: gh-119799: Add missing `_Py_IncRefTotal` to `_Py_NewRefWithLock` (#119800)
X-Git-Tag: v3.14.0a1~1673
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=879d43b705faab0c59f1a6a0042e286f39f3a4ef;p=thirdparty%2FPython%2Fcpython.git

gh-119799: Add missing `_Py_IncRefTotal` to `_Py_NewRefWithLock` (#119800)

The free-threaded refleak builds were reporting negative refcount deltas
in some tests because of a missing `_Py_NewRefWithLock`.
---

diff --git a/Include/internal/pycore_object.h b/Include/internal/pycore_object.h
index 7602248f9564..f63e1da6fba0 100644
--- a/Include/internal/pycore_object.h
+++ b/Include/internal/pycore_object.h
@@ -497,6 +497,9 @@ _Py_NewRefWithLock(PyObject *op)
     if (_Py_TryIncrefFast(op)) {
         return op;
     }
+#ifdef Py_REF_DEBUG
+    _Py_IncRefTotal(_PyThreadState_GET());
+#endif
     _Py_INCREF_STAT_INC();
     for (;;) {
         Py_ssize_t shared = _Py_atomic_load_ssize_relaxed(&op->ob_ref_shared);