From: Maurizio Lombardi <mlombard@redhat.com>
Date: Mon, 31 Mar 2025 16:28:59 +0000 (+0200)
Subject: nvme-pci: skip nvme_write_sq_db on empty rqlist
X-Git-Tag: v6.12.48~131
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=87bbcb73d603641aaee9b153fe033f6abe2d0f41;p=thirdparty%2Fkernel%2Fstable.git

nvme-pci: skip nvme_write_sq_db on empty rqlist

[ Upstream commit 288ff0d10beb069355036355d5f7612579dc869c ]

nvme_submit_cmds() should check the rqlist before calling
nvme_write_sq_db(); if the list is empty, it must return immediately.

Fixes: beadf0088501 ("nvme-pci: reverse request order in nvme_queue_rqs")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 2bddc9f60fecc..fdc9f1df0578b 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -989,6 +989,9 @@ static void nvme_submit_cmds(struct nvme_queue *nvmeq, struct rq_list *rqlist)
 {
 	struct request *req;
 
+	if (rq_list_empty(rqlist))
+		return;
+
 	spin_lock(&nvmeq->sq_lock);
 	while ((req = rq_list_pop(rqlist))) {
 		struct nvme_iod *iod = blk_mq_rq_to_pdu(req);