From: favilances <favilances@proton.me>
Date: Sat, 9 May 2026 18:52:04 +0000 (+0300)
Subject: test-path-util: add coverage for path edge cases
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=87d282a73d9db5cfb2885f37d7fb06194a8ca65e;p=thirdparty%2Fsystemd.git

test-path-util: add coverage for path edge cases

Path utility helpers are used throughout systemd for validation, comparison and manipulation of filesystem paths. Add coverage for additional corner cases around absolute path detection, normalization and prefix matching so regressions in these common helpers are easier to catch.

Co-developed-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: favilances <favilances@proton.me>
---

diff --git a/src/test/test-path-util.c b/src/test/test-path-util.c
index ef4f29172d8..1dc260a4673 100644
--- a/src/test/test-path-util.c
+++ b/src/test/test-path-util.c
@@ -24,8 +24,12 @@ TEST(print_paths) {
 }
 
 TEST(path) {
+        assert_se(!path_is_absolute(NULL));
+        assert_se(!path_is_absolute(""));
         assert_se( path_is_absolute("/"));
+        assert_se( path_is_absolute("//"));
         assert_se(!path_is_absolute("./"));
+        assert_se(!path_is_absolute("foo/bar"));
 
         assert_se( PATH_IN_SET("/bin", "/", "/bin", "/foo"));
         assert_se( PATH_IN_SET("/bin", "/bin"));
@@ -42,6 +46,21 @@ TEST(path) {
         assert_se(!path_equal(NULL, "a"));
 }
 
+TEST(path_is_normalized) {
+        assert_se( path_is_normalized("/"));
+        assert_se( path_is_normalized("/usr/bin"));
+        assert_se( path_is_normalized("usr/bin"));
+
+        assert_se(!path_is_normalized(""));
+        assert_se(!path_is_normalized("."));
+        assert_se(!path_is_normalized("./usr/bin"));
+        assert_se(!path_is_normalized("/usr//bin"));
+        assert_se(!path_is_normalized("/usr/./bin"));
+        assert_se(!path_is_normalized("/usr/bin/."));
+        assert_se(!path_is_normalized("../usr/bin"));
+        assert_se(!path_is_normalized("/usr/../bin"));
+}
+
 TEST(is_path) {
         assert_se(!is_path("foo"));
         assert_se(!is_path("dos.ext"));
@@ -760,6 +779,9 @@ TEST(path_startswith) {
         test_path_startswith_one("/foo/bar/barfoo/", "/foo/bar/barfo", NULL, NULL);
         test_path_startswith_one("/foo/bar/barfoo/", "/foo/bar/bar", NULL, NULL);
         test_path_startswith_one("/foo/bar/barfoo/", "/fo", NULL, NULL);
+        test_path_startswith_one("/usr/binary", "/usr/bin", NULL, NULL);
+        test_path_startswith_one("/foo/barista", "/foo/bar", NULL, NULL);
+        test_path_startswith_one("foo/barista", "foo/bar", NULL, NULL);
 }
 
 static void test_path_startswith_return_leading_slash_one(const char *path, const char *prefix, const char *expected) {