From: Selva Nair Date: Mon, 27 Oct 2025 21:27:41 +0000 (+0100) Subject: pkcs11_management_id_get: Free certificate object after use X-Git-Tag: v2.7_rc1~30 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=87f639c820b8365585fc825ee7ea9cdd86cf88c5;p=thirdparty%2Fopenvpn.git pkcs11_management_id_get: Free certificate object after use Found by ZeroPath Change-Id: I85320b8f1cfc02dfd561916e5637d9481edac59e Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1317 Message-Id: <20251027212747.4161-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33908.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index ce6413563..9afb18164 100644 --- a/src/openvpn/pkcs11.c +++ b/src/openvpn/pkcs11.c @@ -436,9 +436,6 @@ pkcs11_management_id_get(const int index, char **id, char **base64) { pkcs11h_certificate_id_list_t id_list = NULL; pkcs11h_certificate_id_list_t entry = NULL; -#if 0 /* certificate_id seems to be unused -- JY */ - pkcs11h_certificate_id_t certificate_id = NULL; -#endif pkcs11h_certificate_t certificate = NULL; CK_RV rv = CKR_OK; unsigned char *certificate_blob = NULL; @@ -548,6 +545,9 @@ cleanup: pkcs11h_certificate_freeCertificateIdList(id_list); id_list = NULL; + pkcs11h_certificate_freeCertificate(certificate); + certificate = NULL; + free(internal_id); internal_id = NULL;