From: Lennart Poettering <lennart@amutable.com>
Date: Tue, 14 Jul 2026 13:41:09 +0000 (+0200)
Subject: bootspec: log about invalid version strings
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8814cc9f1e898be3b8eb3a1454d00e42879745ab;p=thirdparty%2Fsystemd.git

bootspec: log about invalid version strings
---

diff --git a/src/shared/bootspec.c b/src/shared/bootspec.c
index 77ee218996e..17a3b826d88 100644
--- a/src/shared/bootspec.c
+++ b/src/shared/bootspec.c
@@ -492,9 +492,12 @@ static int boot_entry_load_type1(
                         r = free_and_strdup(&tmp.title, p);
                 else if (streq(field, "sort-key"))
                         r = free_and_strdup(&tmp.sort_key, p);
-                else if (streq(field, "version"))
+                else if (streq(field, "version")) {
+                        if (!version_is_valid(p, VERSION_ALLOW_UNDERSCORE|VERSION_ALLOW_PLUS))
+                                log_syntax(NULL, LOG_WARNING, tmp.path, line, 0, "Version string '%s' is not a valid version, accepting anyway.", p);
+
                         r = free_and_strdup(&tmp.version, p);
-                else if (streq(field, "machine-id"))
+                } else if (streq(field, "machine-id"))
                         r = free_and_strdup(&tmp.machine_id, p);
                 else if (streq(field, "architecture"))
                         r = free_and_strdup(&tmp.architecture, p);