From: Ralph Boehme <slow@samba.org>
Date: Mon, 10 May 2021 09:07:27 +0000 (+0200)
Subject: mdssvc: don't fail mds_add_result() if result is not found in CNID set
X-Git-Tag: tevent-0.11.0~346
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8847f46f75ac5c1a753a0e7da88c522be25ef681;p=thirdparty%2Fsamba.git

mdssvc: don't fail mds_add_result() if result is not found in CNID set

Just skip adding the result to the pending results set, don't return an
error. Returning an error triggers an error at the MDSSVC RPC error which is NOT
what we want here.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14740

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/rpc_server/mdssvc/mdssvc.c b/source3/rpc_server/mdssvc/mdssvc.c
index 1b0badc4851..60934fb63cc 100644
--- a/source3/rpc_server/mdssvc/mdssvc.c
+++ b/source3/rpc_server/mdssvc/mdssvc.c
@@ -567,7 +567,7 @@ bool mds_add_result(struct sl_query *slq, const char *path)
 				sizeof(uint64_t),
 				cnid_comp_fn);
 		if (!found) {
-			return false;
+			return true;
 		}
 	}