From: Salah Triki Date: Thu, 31 Jul 2025 03:15:27 +0000 (+0100) Subject: EDAC/altera: Delete an inappropriate dma_free_coherent() call X-Git-Tag: v5.10.245~108 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=884c20b1d1065410d394513bae4af73d83db0a9b;p=thirdparty%2Fkernel%2Fstable.git EDAC/altera: Delete an inappropriate dma_free_coherent() call commit ff2a66d21fd2364ed9396d151115eec59612b200 upstream. dma_free_coherent() must only be called if the corresponding dma_alloc_coherent() call has succeeded. Calling it when the allocation fails leads to undefined behavior. Delete the wrong call. [ bp: Massage commit message. ] Fixes: 71bcada88b0f3 ("edac: altera: Add Altera SDRAM EDAC support") Signed-off-by: Salah Triki Signed-off-by: Borislav Petkov (AMD) Acked-by: Dinh Nguyen Cc: stable@vger.kernel.org Link: https://lore.kernel.org/aIrfzzqh4IzYtDVC@pc Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 61de8b1ed75ec..9de928346b2b1 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -126,7 +126,6 @@ static ssize_t altr_sdr_mc_err_inject_write(struct file *file, ptemp = dma_alloc_coherent(mci->pdev, 16, &dma_handle, GFP_KERNEL); if (!ptemp) { - dma_free_coherent(mci->pdev, 16, ptemp, dma_handle); edac_printk(KERN_ERR, EDAC_MC, "Inject: Buffer Allocation error\n"); return -ENOMEM;