From: Lucas De Marchi <lucas.demarchi@intel.com>
Date: Wed, 18 Feb 2015 18:47:14 +0000 (-0200)
Subject: libkmod: better explain a signed module layout
X-Git-Tag: v20~33
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=885e90b6f9769c839334779f856f0ca670da5507;p=thirdparty%2Fkmod.git

libkmod: better explain a signed module layout
---

diff --git a/libkmod/libkmod-signature.c b/libkmod/libkmod-signature.c
index 5577305c..6fc06fce 100644
--- a/libkmod/libkmod-signature.c
+++ b/libkmod/libkmod-signature.c
@@ -79,13 +79,6 @@ const char *const pkey_id_type[PKEY_ID_TYPE__LAST] = {
 
 /*
  * Module signature information block.
- *
- * The constituents of the signature section are, in order:
- *
- *	- Signer's name
- *	- Key identifier
- *	- Signature data
- *	- Information block
  */
 struct module_signature {
 	uint8_t algo;        /* Public-key crypto algorithm [enum pkey_algo] */
@@ -99,6 +92,17 @@ struct module_signature {
 
 #define SIG_MAGIC "~Module signature appended~\n"
 
+/*
+ * A signed module has the following layout:
+ *
+ * [ module                  ]
+ * [ signer's name           ]
+ * [ key identifier          ]
+ * [ signature data          ]
+ * [ struct module_signature ]
+ * [ SIG_MAGIC               ]
+ */
+
 bool kmod_module_signature_info(const struct kmod_file *file, struct kmod_signature_info *sig_info)
 {
 	const char *mem;