From: Martin Schwenke <martin@meltin.net>
Date: Fri, 21 Jun 2019 19:29:53 +0000 (+1000)
Subject: ctdb-tcp: Fix signed/unsigned comparisons by declaring as unsigned
X-Git-Tag: samba-4.11.0rc1~50
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=888ecc74ed1a6617b8a0a4450b671cf5f6d88f8b;p=thirdparty%2Fsamba.git

ctdb-tcp: Fix signed/unsigned comparisons by declaring as unsigned

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tcp/tcp_connect.c b/ctdb/tcp/tcp_connect.c
index 385547e0e78..a8fca530470 100644
--- a/ctdb/tcp/tcp_connect.c
+++ b/ctdb/tcp/tcp_connect.c
@@ -300,7 +300,8 @@ static int ctdb_tcp_listen_automatic(struct ctdb_context *ctdb)
 	struct ctdb_tcp *ctcp = talloc_get_type(ctdb->private_data,
 						struct ctdb_tcp);
         ctdb_sock_addr sock;
-	int lock_fd, i;
+	int lock_fd;
+	unsigned int i;
 	const char *lock_path = CTDB_RUNDIR "/.socket_lock";
 	struct flock lock;
 	int one = 1;
diff --git a/ctdb/tcp/tcp_init.c b/ctdb/tcp/tcp_init.c
index b6083666e18..87d628aba93 100644
--- a/ctdb/tcp/tcp_init.c
+++ b/ctdb/tcp/tcp_init.c
@@ -70,7 +70,7 @@ static int ctdb_tcp_add_node(struct ctdb_node *node)
 */
 static int ctdb_tcp_initialise(struct ctdb_context *ctdb)
 {
-	int i;
+	unsigned int i;
 
 	/* listen on our own address */
 	if (ctdb_tcp_listen(ctdb) != 0) {
@@ -147,7 +147,7 @@ static void ctdb_tcp_shutdown(struct ctdb_context *ctdb)
 */
 static int ctdb_tcp_start(struct ctdb_context *ctdb)
 {
-	int i;
+	unsigned int i;
 
 	for (i=0; i < ctdb->num_nodes; i++) {
 		if (ctdb->nodes[i]->flags & NODE_FLAGS_DELETED) {