From: hno <>
Date: Mon, 11 Aug 2003 00:57:08 +0000 (+0000)
Subject: Bug #663: Username not logged into ACCESS.LOG in case of /407
X-Git-Tag: SQUID_3_0_PRE3~22
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=88d3f89034ba5897565aded9d46f7578b56db36e;p=thirdparty%2Fsquid.git

Bug #663: Username not logged into ACCESS.LOG in case of /407

The Basic auth module did not implement the direction call correctly,
indication authentication scheme failure on unsuccessful helper lookup
rather than "completed".


Note: This API and it's interactions with checklist->auth_user_request &
request->auth_user_request looks overly complex for the job. Should be
possible to simplify this a lot I think.
---

diff --git a/src/auth/basic/auth_basic.cc b/src/auth/basic/auth_basic.cc
index 022791c6a7..4ebc42aab1 100644
--- a/src/auth/basic/auth_basic.cc
+++ b/src/auth/basic/auth_basic.cc
@@ -1,5 +1,5 @@
 /*
- * $Id: auth_basic.cc,v 1.28 2003/08/10 11:00:48 robertc Exp $
+ * $Id: auth_basic.cc,v 1.29 2003/08/10 18:57:08 hno Exp $
  *
  * DEBUG: section 29    Authenticator
  * AUTHOR: Duane Wessels
@@ -239,7 +239,7 @@ authenticateBasicDirection(auth_user_request_t * auth_user_request)
         return -1;
 
     case 3:			/* authentication process failed. */
-        return -2;
+        return 0;
     }
 
     return -2;