From: Björn Jacke Date: Sun, 25 Aug 2019 21:03:54 +0000 (+0200) Subject: samba_version.py: avoid inefficient string concatenations X-Git-Tag: talloc-2.3.1~742 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=89288c7e8398d86a24ea19a94908bc85a2664074;p=thirdparty%2Fsamba.git samba_version.py: avoid inefficient string concatenations Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Sat Sep 21 20:50:17 UTC 2019 on sn-devel-184 --- diff --git a/buildtools/wafsamba/samba_version.py b/buildtools/wafsamba/samba_version.py index f0e7b4d0caf..5df7ddbcb3d 100644 --- a/buildtools/wafsamba/samba_version.py +++ b/buildtools/wafsamba/samba_version.py @@ -173,10 +173,10 @@ also accepted as dictionary entries here self.STRING_WITH_NICKNAME = self.STRING def __str__(self): - string="/* Autogenerated by waf */\n" - string+="#define SAMBA_VERSION_MAJOR %u\n" % self.MAJOR - string+="#define SAMBA_VERSION_MINOR %u\n" % self.MINOR - string+="#define SAMBA_VERSION_RELEASE %u\n" % self.RELEASE + string="/* Autogenerated by waf */\n" +\ + "#define SAMBA_VERSION_MAJOR %u\n" % self.MAJOR +\ + "#define SAMBA_VERSION_MINOR %u\n" % self.MINOR +\ + "#define SAMBA_VERSION_RELEASE %u\n" % self.RELEASE if self.REVISION is not None: string+="#define SAMBA_VERSION_REVISION %u\n" % self.REVISION