From: Jason Merrill <jason@redhat.com>
Date: Thu, 11 Sep 2014 12:12:28 +0000 (-0400)
Subject: re PR c++/58678 (pykde4-4.11.2 link error (devirtualization too trigger happy))
X-Git-Tag: releases/gcc-5.1.0~4683
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=89632536fc913518954ea0c4b6d749d898c6a543;p=thirdparty%2Fgcc.git

re PR c++/58678 (pykde4-4.11.2 link error (devirtualization too trigger happy))

	PR c++/58678
	* ipa-devirt.c (ipa_devirt): Don't check DECL_COMDAT.

From-SVN: r215168
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 014014a8c148..f3bfbe005771 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2014-09-11  Jason Merrill  <jason@redhat.com>
+
+	PR c++/58678
+	* ipa-devirt.c (ipa_devirt): Don't check DECL_COMDAT.
+
 2014-09-11  Georg-Johann Lay  <avr@gjlay.de>
 
 	PR target/63223
diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c
index f98a18e7b8f1..948ae2375048 100644
--- a/gcc/ipa-devirt.c
+++ b/gcc/ipa-devirt.c
@@ -3952,8 +3952,7 @@ ipa_devirt (void)
 	    /* Don't use an implicitly-declared destructor (c++/58678).  */
 	    struct cgraph_node *non_thunk_target
 	      = likely_target->function_symbol ();
-	    if (DECL_ARTIFICIAL (non_thunk_target->decl)
-		&& DECL_COMDAT (non_thunk_target->decl))
+	    if (DECL_ARTIFICIAL (non_thunk_target->decl))
 	      {
 		if (dump_file)
 		  fprintf (dump_file, "Target is artificial\n\n");
diff --git a/gcc/testsuite/g++.dg/ipa/devirt-28a.C b/gcc/testsuite/g++.dg/ipa/devirt-28a.C
new file mode 100644
index 000000000000..bdd1682022ab
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ipa/devirt-28a.C
@@ -0,0 +1,15 @@
+// PR c++/58678
+// { dg-options "-O3 -flto -shared -fPIC -Wl,--no-undefined" }
+// { dg-do link { target { gld && fpic } } }
+
+struct A {
+  virtual ~A();
+};
+struct B : A {
+  virtual int m_fn1();
+};
+void fn1(B* b) {
+  delete b;
+}
+
+int main() {}