From: Georg Brandl <georg@python.org>
Date: Fri, 21 Mar 2008 20:46:11 +0000 (+0000)
Subject: Add XXX comments for whoever cleans up getargs.c :)
X-Git-Tag: v3.0a4~90
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=896c317b43260451b3773d905b8fc90027ea50bf;p=thirdparty%2FPython%2Fcpython.git

Add XXX comments for whoever cleans up getargs.c :)
---

diff --git a/Python/getargs.c b/Python/getargs.c
index abe0887bf546..1370e098adcd 100644
--- a/Python/getargs.c
+++ b/Python/getargs.c
@@ -823,6 +823,9 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags,
 			}
 			else
 				return converterr("string", arg, msgbuf, bufsize);
+			/* XXX(gb): this test is completely wrong -- p is a
+			 * byte string while arg is a Unicode. I *think* it should
+			 * check against the size of uarg... */
 			if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr("string without null bytes",
 						  arg, msgbuf, bufsize);
@@ -898,6 +901,7 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags,
 				}
 				format++;
 			}
+			/* XXX(gb): same comment as for 's' applies here... */
 			else if (*p != NULL &&
 				 (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr(