From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Sun, 22 Aug 2010 18:11:02 +0000 (+0000)
Subject: Issue #9512: Made comment more informative.
X-Git-Tag: v3.2a2~172
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=89994b279f8dfe8512293c6b6432129b94871a40;p=thirdparty%2FPython%2Fcpython.git

Issue #9512: Made comment more informative.
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 5f838e57e573..906df16814a1 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -103,8 +103,13 @@ class RotatingFileHandler(BaseRotatingHandler):
 
         If maxBytes is zero, rollover never occurs.
         """
+        # If rotation/rollover is wanted, it doesn't make sense to use another
+        # mode. If for example 'w' were specified, then if there were multiple
+        # runs of the calling application, the logs from previous runs would be
+        # lost if the 'w' is respected, because the log file would be truncated
+        # on each run.
         if maxBytes > 0:
-            mode = 'a' # doesn't make sense otherwise!
+            mode = 'a'
         BaseRotatingHandler.__init__(self, filename, mode, encoding, delay)
         self.maxBytes = maxBytes
         self.backupCount = backupCount