From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Mon, 6 Jan 2020 14:52:43 +0000 (+0000)
Subject: [Minor] Fix GError oversetting in DKIM code
X-Git-Tag: 2.3~141
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8a3312ad64950aab2b494754e32ae974cccf8fa4;p=thirdparty%2Frspamd.git

[Minor] Fix GError oversetting in DKIM code
---

diff --git a/src/libserver/dkim.c b/src/libserver/dkim.c
index 4b66ebbd51..b3efd21492 100644
--- a/src/libserver/dkim.c
+++ b/src/libserver/dkim.c
@@ -1032,6 +1032,17 @@ rspamd_create_dkim_context (const gchar *sig,
 					if (!parser_funcs[param](ctx, c, tlen, err)) {
 						state = DKIM_STATE_ERROR;
 					}
+					if (state == DKIM_STATE_ERROR) {
+						/*
+						 * We need to return from here as state machine won't
+						 * do any more steps after p == end
+						 */
+						if (err) {
+							msg_info_dkim ("dkim parse failed: %e", *err);
+						}
+
+						return NULL;
+					}
 					/* Finish processing */
 					p++;
 				}