From: Victor Stinner Date: Sun, 16 May 2010 00:34:40 +0000 (+0000) Subject: Use with open() as fo: ... instead of try: fo = open(...) finally: fo.close() X-Git-Tag: v2.7rc1~144 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8a470d6039ffe85ea2e0f095fd0f0b960f099b94;p=thirdparty%2FPython%2Fcpython.git Use with open() as fo: ... instead of try: fo = open(...) finally: fo.close() fo is not set if the open() fails. --- diff --git a/Lib/test/list_tests.py b/Lib/test/list_tests.py index e2fa9fe63238..546416ed56c1 100644 --- a/Lib/test/list_tests.py +++ b/Lib/test/list_tests.py @@ -57,13 +57,11 @@ class CommonTest(seq_tests.CommonTest): d.append(d) d.append(400) try: - fo = open(test_support.TESTFN, "wb") - print >> fo, d, - fo.close() - fo = open(test_support.TESTFN, "rb") - self.assertEqual(fo.read(), repr(d)) + with open(test_support.TESTFN, "wb") as fo: + print >> fo, d, + with open(test_support.TESTFN, "rb") as fo: + self.assertEqual(fo.read(), repr(d)) finally: - fo.close() os.remove(test_support.TESTFN) def test_set_subscript(self):