From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 11 Jul 2016 04:05:49 +0000 (+1200)
Subject: dsdb: Improve debugging during SD recursion failure
X-Git-Tag: tdb-1.3.10~412
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8a5a9045ad987ceb26c6c6eea856b8ab56028236;p=thirdparty%2Fsamba.git

dsdb: Improve debugging during SD recursion failure

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Wed Jul 13 02:59:25 CEST 2016 on sn-devel-144
---

diff --git a/source4/dsdb/samdb/ldb_modules/descriptor.c b/source4/dsdb/samdb/ldb_modules/descriptor.c
index 2baf4af352b..e75d79d30e2 100644
--- a/source4/dsdb/samdb/ldb_modules/descriptor.c
+++ b/source4/dsdb/samdb/ldb_modules/descriptor.c
@@ -1144,7 +1144,11 @@ static int descriptor_sd_propagation_object(struct ldb_module *module,
 		ret = ldb_wait(sub_req->handle, LDB_WAIT_ALL);
 	}
 	if (ret != LDB_SUCCESS) {
-		return ldb_module_operr(module);
+		ldb_asprintf_errstring(ldb_module_get_ctx(module),
+				       "descriptor_modify on %s failed: %s",
+				       ldb_dn_get_linearized(msg->dn),
+				       ldb_errstring(ldb_module_get_ctx(module)));
+		return LDB_ERR_OPERATIONS_ERROR;
 	}
 
 	if (sd_propagation_control->critical != 0) {