From: Petr Viktorin <encukou@gmail.com>
Date: Wed, 30 Apr 2025 13:14:24 +0000 (+0200)
Subject: gh-87135: test_threading: Wait on thread, not an Event it sets (GH-133198)
X-Git-Tag: v3.14.0b1~168
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8b26b23a9674a02563f28e4cfbef3d3e39876bfe;p=thirdparty%2FPython%2Fcpython.git

gh-87135: test_threading: Wait on thread, not an Event it sets (GH-133198)

When the event is set the thread might not be done yet.

This is a fix-up for commit 4ebbfcf30e0e2d87ff6036d4d1de0f6f0ef7c46a
---

diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py
index b76888636265..814c00ca0fd7 100644
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -1219,18 +1219,18 @@ class ThreadTests(BaseTestCase):
             import threading
             done = threading.Event()
 
-            def loop():
+            def set_event():
                 done.set()
 
-
             class Cycle:
                 def __init__(self):
                     self.self_ref = self
-                    self.thr = threading.Thread(target=loop, daemon=True)
+                    self.thr = threading.Thread(target=set_event, daemon=True)
                     self.thr.start()
-                    done.wait()
+                    self.thr.join()
 
                 def __del__(self):
+                    assert done.is_set()
                     assert not self.thr.is_alive()
                     self.thr.join()
                     assert not self.thr.is_alive()