From: Michael W. Hudson <mwh@python.net>
Date: Tue, 5 Mar 2002 15:37:18 +0000 (+0000)
Subject: backport gvanrossum's checkin of
X-Git-Tag: v2.2.1c1~114
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8b34e6146145e50cde974cbbfd087838a05871c2;p=thirdparty%2FPython%2Fcpython.git

backport gvanrossum's checkin of
    revision 1.115 of test_descr.py

SF patch 514641 (Naofumi Honda) - Negative ob_size of LongObjects

Due to the bizarre definition of _PyLong_Copy(), creating an instance
of a subclass of long with a negative value could cause core dumps
later on.  Unfortunately it looks like the behavior of _PyLong_Copy()
is quite intentional, so the fix is more work than feels comfortable.

This fix is almost, but not quite, the code that Naofumi Honda added;
in addition, I added a test case.



I haven't quite worked out how to port the fix yet, but the test cases
can go straight over.
---

diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
index dd95ddeb91e2..e667efb18af7 100644
--- a/Lib/test/test_descr.py
+++ b/Lib/test/test_descr.py
@@ -1748,6 +1748,10 @@ def inherits():
     verify((a + 0).__class__ is long)
     verify((0 + a).__class__ is long)
 
+    # Check that negative clones don't segfault
+    a = longclone(-1)
+    vereq(a.__dict__, {})
+
     class precfloat(float):
         __slots__ = ['prec']
         def __init__(self, value=0.0, prec=12):