From: Michael Adam <obnox@samba.org>
Date: Wed, 3 Feb 2016 10:41:23 +0000 (+0100)
Subject: lib:socket: fix CID 1350009 - illegal memory accesses  (BUFFER_SIZE_WARNING)
X-Git-Tag: tevent-0.9.27~15
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8b36428b195f6e1d1063f1abccb718f2665d271f;p=thirdparty%2Fsamba.git

lib:socket: fix CID 1350009 - illegal memory accesses  (BUFFER_SIZE_WARNING)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11735

Pair-Programmed-With: Guenther Deschner <gd@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
---

diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c
index cf094f0b4c5..847fa6255ba 100644
--- a/lib/socket/interfaces.c
+++ b/lib/socket/interfaces.c
@@ -140,6 +140,11 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed)
 		return;
 	}
 
+	if (strlen(name) >= IF_NAMESIZE) {
+		DBG_ERR("Interface name too long.");
+		goto done;
+	}
+
 	strncpy(ifr.ifr_name, name, IF_NAMESIZE);
 
 	ifr.ifr_data = (void *)&edata;