From: Björn Jacke <bj@sernet.de>
Date: Sun, 25 Aug 2019 21:02:00 +0000 (+0200)
Subject: samba_bundled.py avoid inefficient string concatenations
X-Git-Tag: talloc-2.3.1~744
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8b43aabecbad2084169b229859bf5bfc9e2ddac0;p=thirdparty%2Fsamba.git

samba_bundled.py avoid inefficient string concatenations

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/buildtools/wafsamba/samba_bundled.py b/buildtools/wafsamba/samba_bundled.py
index 60ce7da7232..5f080dd8a7a 100644
--- a/buildtools/wafsamba/samba_bundled.py
+++ b/buildtools/wafsamba/samba_bundled.py
@@ -204,8 +204,8 @@ def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
     version_checks = '%s >= %s' % (pkg, minversion)
     if maxversion is not None:
         version_checks += ' %s <= %s' % (pkg, maxversion)
-    for v in version_blacklist:
-        version_checks += ' %s != %s' % (pkg, v)
+
+    version_checks += "".join(' %s != %s' % (pkg, v) for v in version_blacklist)
 
     # try pkgconfig first
     if (conf.CHECK_CFG(package=pkg,