From: Andreas Schneider <asn@samba.org>
Date: Mon, 18 Feb 2013 16:08:21 +0000 (+0100)
Subject: ndr: Comparing an array to null is always true.
X-Git-Tag: tevent-0.9.18~111
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8bfbb81bcd5a70280f49fbe3ab67ccf035fdeade;p=thirdparty%2Fsamba.git

ndr: Comparing an array to null is always true.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
---

diff --git a/librpc/ndr/ndr_sec_helper.c b/librpc/ndr/ndr_sec_helper.c
index 66b0013b9cb..ea082d148dd 100644
--- a/librpc/ndr/ndr_sec_helper.c
+++ b/librpc/ndr/ndr_sec_helper.c
@@ -228,7 +228,7 @@ enum ndr_err_code ndr_pull_dom_sid28(struct ndr_pull *ndr, int ndr_flags, struct
 	if (!NDR_ERR_CODE_IS_SUCCESS(status)) {
 		/* handle a w2k bug which send random data in the buffer */
 		ZERO_STRUCTP(sid);
-	} else if (sid->num_auths == 0 && sid->sub_auths) {
+	} else if (sid->num_auths == 0) {
 		ZERO_STRUCT(sid->sub_auths);
 	}