From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Tue, 20 Oct 2020 05:20:19 +0000 (+0900)
Subject: network: make route_configure() return 0 on success
X-Git-Tag: v247-rc1~29^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8c212f76c246d9c3780b1de9b12dc21b8775561e;p=thirdparty%2Fsystemd.git

network: make route_configure() return 0 on success

Previously, route_configure() always returns 1 on success, and never
returns 0. It is not necessary to return positive value.
---

diff --git a/src/network/networkd-route.c b/src/network/networkd-route.c
index 707660df3c0..4ad9adc9202 100644
--- a/src/network/networkd-route.c
+++ b/src/network/networkd-route.c
@@ -1130,7 +1130,7 @@ int route_configure(
                 }
         }
 
-        return 1;
+        return 0;
 }
 
 static int route_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
@@ -1201,8 +1201,8 @@ int link_set_routes(Link *link) {
                         r = route_configure(rt, link, route_handler, NULL);
                         if (r < 0)
                                 return log_link_warning_errno(link, r, "Could not set routes: %m");
-                        if (r > 0)
-                                link->route_messages++;
+
+                        link->route_messages++;
                 }
 
         if (link->route_messages == 0) {