From: Noel Power Date: Wed, 22 May 2019 10:32:15 +0000 (+0000) Subject: s4/smb_server/smb: cppcheck: Fix uninitvar & uninitStructMember errors X-Git-Tag: ldb-2.0.5~510 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8c49cf70fc519059b8606bc6432c69b2d5ec06ab;p=thirdparty%2Fsamba.git s4/smb_server/smb: cppcheck: Fix uninitvar & uninitStructMember errors Fixes the following errors (note: existing code is safe the way it is currently all accesses to the structure are 'after' it is assigned) source4/smb_server/smb/negprot.c:447: error: uninitvar: Uninitialized variable: blob <--[cppcheck] source4/smb_server/smb/negprot.c:453: error: uninitStructMember: Uninitialized struct member: blob.data <--[cppcheck] source4/smb_server/smb/negprot.c:447: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:453: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:454: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] source4/smb_server/smb/negprot.c:455: error: uninitStructMember: Uninitialized struct member: blob.length <--[cppcheck] Signed-off-by: Noel Power Reviewed-by: Andreas Schneider --- diff --git a/source4/smb_server/smb/negprot.c b/source4/smb_server/smb/negprot.c index cc95a607746..a6177a72019 100644 --- a/source4/smb_server/smb/negprot.c +++ b/source4/smb_server/smb/negprot.c @@ -371,7 +371,7 @@ static void reply_nt1(struct smbsrv_request *req, uint16_t choice) struct cli_credentials *server_credentials; struct gensec_security *gensec_security; DATA_BLOB null_data_blob = data_blob(NULL, 0); - DATA_BLOB blob; + DATA_BLOB blob = data_blob_null; const char *oid; NTSTATUS nt_status;