From: Timo Sirainen <tss@iki.fi>
Date: Mon, 4 May 2009 22:10:03 +0000 (-0400)
Subject: settings_parser_check() return value was checked wrong.
X-Git-Tag: 2.0.alpha1~842
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8c4b2e0734326ef8e534f25e8ee78ace1fc22d15;p=thirdparty%2Fdovecot%2Fcore.git

settings_parser_check() return value was checked wrong.

--HG--
branch : HEAD
---

diff --git a/src/dict/dict-settings.c b/src/dict/dict-settings.c
index cb6c3b7943..bf6806b44d 100644
--- a/src/dict/dict-settings.c
+++ b/src/dict/dict-settings.c
@@ -56,7 +56,7 @@ struct dict_settings *dict_settings_read(void)
 			settings_parser_get_error(parser));
 	}
 
-	if (settings_parser_check(parser, settings_pool, &error) < 0)
+	if (!settings_parser_check(parser, settings_pool, &error))
 		i_fatal("Invalid settings: %s", error);
 
 	set = settings_parser_get(parser);
diff --git a/src/lib-master/master-service-settings.c b/src/lib-master/master-service-settings.c
index 3eb8978b72..274828adc2 100644
--- a/src/lib-master/master-service-settings.c
+++ b/src/lib-master/master-service-settings.c
@@ -187,7 +187,7 @@ int master_service_settings_read(struct master_service *service,
 						   keys);
 	}
 
-	if (settings_parser_check(parser, service->set_pool, &error) < 0) {
+	if (!settings_parser_check(parser, service->set_pool, &error)) {
 		*error_r = t_strdup_printf("Invalid settings: %s", error);
 		return -1;
 	}