From: Alexander Færøy <ahf@torproject.org>
Date: Fri, 22 Jun 2018 22:44:33 +0000 (+0200)
Subject: Fix potential memory leak in hs_helper_build_intro_point().
X-Git-Tag: tor-0.3.2.11~10^2^2~2^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8c8941eb297a166aa7b1b915a543bf97b3a63039;p=thirdparty%2Ftor.git

Fix potential memory leak in hs_helper_build_intro_point().

This patch fixes a potential memory leak in
hs_helper_build_intro_point() where a `goto done` is called before the
`intro_point` variable have been assigned to the value of the `ip`
variable.

See: Coverity CID 1437460
See: Coverity CID 1437456
---

diff --git a/src/test/hs_test_helpers.c b/src/test/hs_test_helpers.c
index 3f0d6a9413..f7e054b1d1 100644
--- a/src/test/hs_test_helpers.c
+++ b/src/test/hs_test_helpers.c
@@ -85,6 +85,9 @@ hs_helper_build_intro_point(const ed25519_keypair_t *signing_kp, time_t now,
 
   intro_point = ip;
  done:
+  if (intro_point == NULL)
+    tor_free(ip);
+
   return intro_point;
 }