From: Gary Lockyer <gary@catalyst.net.nz>
Date: Fri, 7 Jun 2019 02:34:44 +0000 (+1200)
Subject: lib ldb ldb_key_value: csbuild unused parm module
X-Git-Tag: ldb-2.0.5~391
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d2cfd45f84e166b61a1b80edef113f7410ac954;p=thirdparty%2Fsamba.git

lib ldb ldb_key_value: csbuild unused parm module

Fixes csbuild error.

Error: COMPILER_WARNING:
lib/ldb/ldb_key_value/ldb_kv.c: scope_hint: In function
‘ldb_kv_guid_to_key’
lib/ldb/ldb_key_value/ldb_kv.c:157:43: warning: unused parameter
‘module’ [-Wunused-parameter]

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/ldb/ldb_key_value/ldb_kv.c b/lib/ldb/ldb_key_value/ldb_kv.c
index 09ed3f81674..aa857cb413a 100644
--- a/lib/ldb/ldb_key_value/ldb_kv.c
+++ b/lib/ldb/ldb_key_value/ldb_kv.c
@@ -153,8 +153,7 @@ failed:
 }
 
 /* The caller is to provide a correctly sized key */
-int ldb_kv_guid_to_key(struct ldb_module *module,
-		       struct ldb_kv_private *ldb_kv,
+int ldb_kv_guid_to_key(struct ldb_kv_private *ldb_kv,
 		       const struct ldb_val *GUID_val,
 		       struct ldb_val *key)
 {
@@ -185,7 +184,7 @@ int ldb_kv_idx_to_key(struct ldb_module *module,
 	struct ldb_dn *dn;
 
 	if (ldb_kv->cache->GUID_index_attribute != NULL) {
-		return ldb_kv_guid_to_key(module, ldb_kv, idx_val, key);
+		return ldb_kv_guid_to_key(ldb_kv, idx_val, key);
 	}
 
 	dn = ldb_dn_from_ldb_val(mem_ctx, ldb, idx_val);
@@ -257,7 +256,7 @@ struct ldb_val ldb_kv_key_msg(struct ldb_module *module,
 	}
 	key.length = talloc_get_size(key.data);
 
-	ret = ldb_kv_guid_to_key(module, ldb_kv, guid_val, &key);
+	ret = ldb_kv_guid_to_key(ldb_kv, guid_val, &key);
 
 	if (ret != LDB_SUCCESS) {
 		errno = EINVAL;
diff --git a/lib/ldb/ldb_key_value/ldb_kv.h b/lib/ldb/ldb_key_value/ldb_kv.h
index fa745184965..a8ba3fd60d9 100644
--- a/lib/ldb/ldb_key_value/ldb_kv.h
+++ b/lib/ldb/ldb_key_value/ldb_kv.h
@@ -281,8 +281,7 @@ struct ldb_val ldb_kv_key_dn(TALLOC_CTX *mem_ctx,
 struct ldb_val ldb_kv_key_msg(struct ldb_module *module,
 			     TALLOC_CTX *mem_ctx,
 			      const struct ldb_message *msg);
-int ldb_kv_guid_to_key(struct ldb_module *module,
-		       struct ldb_kv_private *ldb_kv,
+int ldb_kv_guid_to_key(struct ldb_kv_private *ldb_kv,
 		       const struct ldb_val *GUID_val,
 		       struct ldb_val *key);
 int ldb_kv_idx_to_key(struct ldb_module *module,
diff --git a/lib/ldb/ldb_key_value/ldb_kv_index.c b/lib/ldb/ldb_key_value/ldb_kv_index.c
index ae8f1101302..eead0c7f56f 100644
--- a/lib/ldb/ldb_key_value/ldb_kv_index.c
+++ b/lib/ldb/ldb_key_value/ldb_kv_index.c
@@ -608,7 +608,7 @@ int ldb_kv_key_dn_from_idx(struct ldb_module *module,
 	}
 
 	/* The ldb_key memory is allocated by the caller */
-	ret = ldb_kv_guid_to_key(module, ldb_kv, &list->dn[index], ldb_key);
+	ret = ldb_kv_guid_to_key(ldb_kv, &list->dn[index], ldb_key);
 	TALLOC_FREE(list);
 
 	if (ret != LDB_SUCCESS) {