From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Fri, 10 Apr 2026 09:05:56 +0000 (+0300)
Subject: repository: fix repo_init() memleak due to missing _clear()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d2ffcf4b4a3a55c56c57c8df617516c25d98380;p=thirdparty%2Fgit.git

repository: fix repo_init() memleak due to missing _clear()

There is an old pre-existing memory leak in repo_init() due to failing
to call clear_repository_format() in the error case.

It went undetected because a specific bug is required to trigger it:
enable a v1 extension in a repository with format v0. Obviously this
can only happen in a development environment, so it does not trigger
in normal usage, however the memleak is real and needs fixing.

Fix it by also calling clear_repository_format() in the error case.

Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/repository.c b/repository.c
index 9e5537f539..192d6dc9c4 100644
--- a/repository.c
+++ b/repository.c
@@ -323,6 +323,7 @@ int repo_init(struct repository *repo,
 	return 0;
 
 error:
+	clear_repository_format(&format);
 	repo_clear(repo);
 	return -1;
 }