From: Olivier Houchard <ohouchard@haproxy.com>
Date: Tue, 14 Oct 2025 16:11:31 +0000 (+0200)
Subject: BUG/MEDIUM: stick-tables: Don't forget to dec count on failure.
X-Git-Tag: v3.3-dev10~13
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d31784c0f1368b5004f089b4f5512298766dfaf;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: stick-tables: Don't forget to dec count on failure.

In stksess_new(), if we failed to allocate memory for the new stksess,
don't forget to decrement the table entry count, as nobody else will
do it for us.
An artificially high count could lead to at least purging entries while
there is no need to.

This should be backported up to 2.8.

WIP decrement current on allocation failure
---

diff --git a/src/stick_table.c b/src/stick_table.c
index 9a0809cb3..5532fc679 100644
--- a/src/stick_table.c
+++ b/src/stick_table.c
@@ -456,7 +456,8 @@ struct stksess *stksess_new(struct stktable *t, struct stktable_key *key)
 			stksess_setkey(t, ts, key);
 			stksess_setkey_shard(t, ts, key);
 		}
-	}
+	} else
+		HA_ATOMIC_DEC(&t->current);
 
 	return ts;
 }