From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 25 Oct 2017 19:01:55 +0000 (-0400)
Subject: Test for EXCLUDE constraint duplicated index
X-Git-Tag: rel_1_2_0~39^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d318dee6cdccd0751ad8b0832774398a45f9cdb;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Test for EXCLUDE constraint duplicated index

An EXCLUDE constraint makes an index just like a UNIQUE does;
get_indexes() will receive this.  Test that this works out the
same way as it does for a UNIQUE.

Change-Id: I02ac7cbbb1ca0d1fcdcdbe9a8b8bd1ffee3e496c
Fixes: #4122
---

diff --git a/test/dialect/postgresql/test_reflection.py b/test/dialect/postgresql/test_reflection.py
index a1942ab303..5c52195d13 100644
--- a/test/dialect/postgresql/test_reflection.py
+++ b/test/dialect/postgresql/test_reflection.py
@@ -13,7 +13,8 @@ from sqlalchemy import Table, Column, MetaData, Integer, String, \
 from sqlalchemy import exc
 import sqlalchemy as sa
 from sqlalchemy.dialects.postgresql import base as postgresql
-from sqlalchemy.dialects.postgresql import ARRAY, INTERVAL
+from sqlalchemy.dialects.postgresql import ARRAY, INTERVAL, TSRANGE
+from sqlalchemy.dialects.postgresql import ExcludeConstraint
 import re
 
 
@@ -971,6 +972,36 @@ class ReflectionTest(fixtures.TestBase):
         self.assert_('uc_a' not in indexes)
         self.assert_('uc_a' in constraints)
 
+    @testing.requires.btree_gist
+    @testing.provide_metadata
+    def test_reflection_with_exclude_constraint(self):
+        m = self.metadata
+        Table(
+            't', m,
+            Column('id', Integer, primary_key=True),
+            Column('period', TSRANGE),
+            ExcludeConstraint(('period', '&&'), name='quarters_period_excl')
+        )
+
+        m.create_all()
+
+        insp = inspect(testing.db)
+
+        # PostgreSQL will create an implicit index for an exclude constraint.
+        # we don't reflect the EXCLUDE yet.
+        eq_(
+            insp.get_indexes('t'),
+            [{'unique': False, 'name': 'quarters_period_excl',
+              'duplicates_constraint': 'quarters_period_excl',
+              'dialect_options': {'postgresql_using': 'gist'},
+              'column_names': ['period']}]
+        )
+
+        # reflection corrects for the dupe
+        reflected = Table('t', MetaData(testing.db), autoload=True)
+
+        eq_(set(reflected.indexes), set())
+
     @testing.provide_metadata
     def test_reflect_unique_index(self):
         insp = inspect(testing.db)
@@ -1026,6 +1057,7 @@ class ReflectionTest(fixtures.TestBase):
         })
 
 
+
 class CustomTypeReflectionTest(fixtures.TestBase):
 
     class CustomType(object):
diff --git a/test/requirements.py b/test/requirements.py
index e01c686aee..dac9494004 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -829,18 +829,23 @@ class DefaultRequirements(SuiteRequirements):
     def duplicate_key_raises_integrity_error(self):
         return fails_on("postgresql+pg8000")
 
-    @property
-    def hstore(self):
-        def check_hstore(config):
+    def _has_pg_extension(self, name):
+        def check(config):
             if not against(config, "postgresql"):
                 return False
-            try:
-                config.db.execute("SELECT 'a=>1,a=>2'::hstore;")
-                return True
-            except Exception:
-                return False
+            count = config.db.scalar(
+                "SELECT count(*) FROM pg_extension "
+                "WHERE extname='%s'" % name)
+            return bool(count)
+        return only_if(check, "needs %s extension" % name)
 
-        return only_if(check_hstore)
+    @property
+    def hstore(self):
+        return self._has_pg_extension("hstore")
+
+    @property
+    def btree_gist(self):
+        return self._has_pg_extension("btree_gist")
 
     @property
     def range_types(self):